User "Brion VIBBER" posted a comment on MediaWiki.r87764.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87764#c16747
Commit summary:

count the errors and show them next to the submit button (this helps when the 
errors are scrolled off page)

Comment:

fyi -- should be able to do this in one lookup like:

$( '#mwe-upwiz-stepdiv-details' ).find( 'input.mwe-error, textarea.mwe-error, 
input.mwe-validator-error, textarea.mwe-validator-error' ).length

However... if one field has both .mwe-error and .mwe-validator-error on it, 
then this will also avoid duplicating them, counting the field only once 
instead of twice. If it should be counted twice, then leave as is -- if they're 
mutually exclusive than it doesn't matter, use whichever is more convenient.


_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to