User "Krinkle" posted a comment on MediaWiki.r88012. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88012#c16902 Commit summary:
Adding qunit tests for isIPv4Address and isIPv6Address in mw.util Comment: I'm not sure we can or should. They don't test the same code. PHPUnit tests the IP Class from IP.php, whereas these QUnit tests test the behaviour of the isIP* functions in mediawiki.util.js, they do not behave competely the same (for example when passing no arguments, or when passing an IP-range). I only used the tests examples (ie. "...", "::0:", etc.) from the PHP Unit tests. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
