User "Bryan" posted a comment on MediaWiki.r86212. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86212#c16931 Commit summary:
(Follow-up r86169) Needed supress warnings around iconv Also make it try to detect if a jpeg file comment has textual data, or is random binary stuff. Comment: If there should always be a wfSurpressWarnings() around iconv, there should be a wrapper function which does that. This function could then also invoke the compat iconv. <pre> function wfIconv( $src, $target, $str ) { if ( function_exists( 'iconv' ) { wfSurpressWarnings(); iconv( $src, $target, $str ); wfRestoreWarnings(); } else { Fallback::iconv( $src, $target, $str ); } } _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview