User "Brion VIBBER" changed the status of MediaWiki.r88276. Old Status: fixme New Status: reverted
User "Brion VIBBER" also posted a comment on MediaWiki.r88276. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88276#c17122 Commit summary: mw.util.getActionFrom incorrectly returns null * Return 'view' for urls like: - /w/index.php?title=Foobar * Anything else, fallback to 'view' (just like PHP does) * JSHint - ['view'] is better written in dot notation. - 'action' was already defined on line 235. - 'actionRe' is defined multiple times (loop). - Use '===' to compare with '0'. - 'title' is already defined. >> The code check passed 100%! * Adding QUnit test for getActionFrom and getTitleFrom (Follow-up r87964) Comment: These functions were added in a revision that's now been reverted, so they no longer exist on trunk. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
