User "Aaron Schulz" posted a comment on MediaWiki.r88639.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88639#c17145
Commit summary:

(bug 27756, bug 26328) Removed AJAX preview (on diff) loading: causes more 
trouble than it's worth. If any reincarnation is added it must handle these 
problems (which involve rethinking the page loading model). Also, diffs use the 
current page cache when possible. The focus should be on avoiding 
fragmentation. Additionally, diffonly=0 in review links could be altered (we 
already enumerate template/file changes).

Comment:

The slowness on enwiki can be dealt with for now, if nothing else, by removing 
(or even inverting) the diffonly=0 param in links. This would have no drawback 
there. The trial there is ending though, so I'm not sure that's a priority atm.

Also, if you can see the diff but have to wait 20 seconds for the preview it's 
still bad. Perhaps users review before it loads...but in that case why bother 
with diffonly=0?

I'm looking into either avoiding diffonly=0 and/or caching pending revs (even 
daemon could populate it if needed to avoid users getting a first-miss 
penalty). Avoiding fragmentation will also help here.

I talked to Chad about removing this beforehand on IRC. I lost any confidence 
that those bugs or the r77896 comment have any chance of being dealt with. If 
anyone is interested in adding a more thought-out, fixed, version of deferred 
loading in the core, that's another matter.

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to