User "Freakolowsky" posted a comment on MediaWiki.r89263. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89263#c17577 Commit summary:
* suggestion for ExtensionUpdater that would handle DB install/update of extension from DatabaseUpdater * could also generate default code for LocalSettingsGenerator * revert if silly :D Comment: Currently it only works for the installer part (net even sure if that works correctly). You can specify a updater function trough the hook but DatabaseUpdater passes itself to that function as a parameter. That class has all the addXXX and applyPatch functions as protected, so you actually can't do nothing useful with it other that using the DB directly and doing DDL stuff. So instead of opening up the updater functions i think it would be better to have an updater specific to the extension inside. This way you can besides taking care of the installation process also handle the potential DB upgrade of extension specific parts. You can also use this updater to pass some defaults to LocalSettingsGenerator. The current code works, but it's very limited. Generally i think this would be a useful feature. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
