User "IAlex" posted a comment on MediaWiki.r89407. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89407#c17779 Commit summary:
Don't execute the loop if there's no X-Forwarded-For header, also don't use isset() to check only for null Comment: The problem is that <code>$ip</code> is declared as static, meaning that the entire code can be executed only once, and it is not possible to reset it without throwing an exception using the GetIP hook. Should we move this to a class, e.g. WebRequest since it's heavily request-dependant, and so we would be able to run it more than once? _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
