User "Krinkle" changed the status of MediaWiki.r87975. Old Status: new New Status: ok
User "Krinkle" also posted a comment on MediaWiki.r87975. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87975#c17916 Commit summary: Fix width of live log in installer, so that it floats correctly to the right Comment: <code>#config-live-log</code> isn't floated. How does this fix anything ? From what I can see it moves the issue. The problem is that the sidebar (<code>#config-page-list</code>) has a width of 12em (18em including the padding margin) and the page content itself has a fluid width, so no matter what percentage it is set to it will always misalign with the rest of the paragraphs, and there will always be a case where it jumps below the sidebar if it's too wide. compare: * <code>#config-live-log { width: 75%</code>: narrow window (http://toolserver.org/~krinkle/tmp/87975-narrow-75.png) * <code>#config-live-log { width: 70%</code>: narrow window (http://toolserver.org/~krinkle/tmp/87975-wide-70.png) * <code>#config-live-log { width: 75%</code>: wide window (http://toolserver.org/~krinkle/tmp/87975-narrow-75.png) * <code>#config-live-log { width: 70%</code>: wide window (http://toolserver.org/~krinkle/tmp/87975-wide-70.png) I think neither is better or worse, they're all misaligned. The results may vary from browser to browser, though. But sadly it's implossible for a {[tag|textarea|open}} to get the same width as the paragraphs or the infobox (next to the sidebar). Reason being that those can have an <code>auto<code> width and/or <code>overflow:hidden</code> to get the proper size, where a textarea can't. It's not hopeless though, it can be fixed by removing the width all together (letting it fallback to width:100%) and wrap the {{tag|textarea|open}} in a {{tag|div|open}} that can be adapted to the context. Done in r89835. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
