User "Nikerabbit" changed the status of MediaWiki.r90038. Old Status: deferred New Status: new
User "Nikerabbit" also posted a comment on MediaWiki.r90038. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90038#c18029 Commit summary: * Initial commit Comment: <pre> +/* run this script out of your $IP/maintenance folder */ +require_once( 'Maintenance.php' ); </pre> I don't think this is the best way to do this. I've used: <pre> if ( getenv( 'MW_INSTALL_PATH' ) !== false ) { $IP = getenv( 'MW_INSTALL_PATH' ); } else { $dir = dirname( __FILE__ ); $IP = "$dir/../.."; } require_once( "$IP/maintenance/commandLine.inc" ); </pre> +$this->output('Updating "'.$titleObj->getText().'" ... '); +$this->output('complete'."\n"); You could use the second parameter for output() for this. Doesn't matter so much if you are not throwing errors in the middle. Here the indentation looks horrible. I suggest using tabs only up to the current indentation level and do the rest with spaces if at all. Here you could just split the line after array( to avoid the extra indentation. <pre> +$wgExIndexMIMETypes = array( 'application/pdf', + 'application/xml', + 'text/xml', + 'application/msword' , + 'text/plain', + 'text/html' ); </pre> Running stylize script over the code would be nice. I haven't seen $wgEx prefixed used elsewhere. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
