User "Brion VIBBER" changed the status of MediaWiki.r86735. Old Status: new New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r86735. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86735#c18114 Commit summary: Followup to r86312 <ialex> Reedy: that rev is breaking usage of {{PAGENAME}} in messages, such as in MediaWiki:Noarticles Allowing optional passing in of a Title object (like it may be set in Message), but if it's not set, or not a title object, fall back and use $wgTitle (I'm sorry!) Comment: This rev seems to mostly revert r86312, but puts a couple other bits in differently. It's unclear from the commit comments what problem it's actually meant to solve, and whether it fixes or breaks anything in particular. Seems to need test cases to show what's actually going on here... it '''looks''' right in this version ($this->title on the Message object doesn't get set unless a caller sets it to something, so it _should_ default to null and thus fall through to $wgTitle). _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
