User "Aaron Schulz" posted a comment on MediaWiki.r80988.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80988#c18127
Commit summary:

HTMLForm: All section headers and footers. Added an optional second $section 
parameter to addHeaderText and addFooterText.

Comment:

$section = $this->displaySection( $value, $key );

+if ( isset( $this->mSectionHeaders[$key] ) ) {
+$section = $this->mSectionHeaders[$key] . $section;
+}

Is $section supposed to be overridden like that?

Also, the function comments are out of data.

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to