User "Platonides" posted a comment on MediaWiki.r90530. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90530#c18436 Commit summary:
Revert r90483, if tesla has problems, it should get proper permissions to the affected folders (or change the test to use a temp folder) The test was not consistent, since first time it would use the svn file, which renames it... and on next run it would be missing! I added the '.' to the unlik() step so it properly cleans up. Opened bug 29512 for the strange UploadStash behavior. However, although it passes now most of the times, it sometimes fails with the strange exception: Only variables should be passed by reference phase3/includes/upload/UploadStash.php:143 phase3/tests/phpunit/includes/upload/UploadStashTest.php:22 phase3/tests/phpunit/MediaWikiTestCase.php:64 phase3/tests/phpunit/MediaWikiPHPUnitCommand.php:20 phase3/tests/phpunit/phpunit.php:60 Comment: This should read 'Revert r90349' _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
