User "Aaron Schulz" changed the status of MediaWiki.r87697. Old Status: new New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87697#c0 Commit summary: Fix exception thrown in mw.util.addPortletLink * As of jQuery 1.4.4, Sizzle's query must be a string (it does a query.replace call before everything else). It fails otherwise. * In REL1_17 and 1.17wmf1 this isn't a problem since jQuery 1.4.2 is there, in which Sizzle didn't fail on non-strings yet. * Nonetheless this is undocumented support, we should make sure that the variable passed is a string on our side * Adding a check for it in mw.util.addPortletLink's nextnode argument. * Adding a test to mw.util.test that calls addPortletLink with three arguments, making nextnode implied undefined/null. This test returned "ERROR" before I made the fix in mw.util.addPortletLink. Exact error: TypeError: Result of expression 'query' [undefined] is not an object. Origin: line 4085 of jQuery/mediaWiki module load. Line 4081: Sizzle = function( query, context, extra, seed ) { Line 4085: query = query.replace(/\=\s*([^'"\]]*)\s*\]/g, "='$1']"); _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
