User "Krinkle" posted a comment on MediaWiki.r90743. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90743#c18725 Commit summary:
Directionality improvements as part of bug 6100 (under $wgBetterDirectionality): * Add CSS that should fix all LTR/LTR text on both LTR/RTL wikis, for the editsection link, TOC, and lists (ul/ol). * Add a class mw-content-ltr/rtl for that. * Change the divs on CategoryPage so it works wit that CSS. This is the last relatively major issue for bug 6100. Comment: Why is there both a seperate class and a dir-attribtue in between ? Does that mean the page structure is like this ? <pre> <div class="mw-content-rtl"> <foo dir="rtl"> <span class="editsection"></span> </foo> </div> </pre> Wouldn't: <pre> <div class="mw-content" dir="rtl"> ... <span class="editsection"></span> ... </div> </pre> make more sense ? _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview