User "Simetrical" changed the status of MediaWiki.r90819. Old Status: new New Status: fixme
User "Simetrical" also posted a comment on MediaWiki.r90819. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90819#c18750 Commit summary: Made '^' (XOR) in recCheckCondition() act as a one-hot detector. Before r28805, XOR silently ignored subconds beyond the first two. After r28805, XOR passed iff an odd number of subconds passed. It now passes iff exactly one subcond passes. This should be more intuitive, as I highly doubt anyone using 3+ subconds was doing it correctly before. Comment: This is not how xor works in programming languages or mathematics. If you xor multiple things, it is indeed true if and only if an odd number are true. If you want an "only one" operator, you shouldn't call it "^" -- that's extremely confusing. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
