User "Aaron Schulz" posted a comment on MediaWiki.r90819.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90819#c18774
Commit summary:

Made '^' (XOR) in recCheckCondition() act as a one-hot detector. Before r28805, 
XOR silently ignored subconds beyond the first two. After r28805, XOR passed 
iff an odd number of subconds passed. It now passes iff exactly one subcond 
passes. This should be more intuitive, as I highly doubt anyone using 3+ 
subconds was doing it correctly before.

Comment:

Sounds fine by me. If there are 3+ items for '^' it should give some kind of 
error though (not silently ignore stuff).

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to