User "Brion VIBBER" changed the status of MediaWiki.r83744. Old Status: new New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r83744. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83744#c18814 Commit summary: Followup to r83715: use internal HTTP client, handle exception when previewing * Replace own HTTP client with the generic HTTP::get (as per code review) * SpecialBannerLoaderException needs to be handled when previewing banners. This exception needs to handled in the user interface, currently a newly introduced 'centralnotice-nopreview' message is displayed in case of banner generation failure. Further work: * Unfortunately, UI code is full of duplication and should probably be refactored. * getDonationAmount() and friends should factored out of the SpecialBannerLoader Comment: This adds a lot of duplication -- the same try/catch block and dual calls to getHtmlNotice & wfMsg are done over and over. It looks like that try/catch block might belong *in* getHtmlNotice...? _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
