User "Bawolff" posted a comment on MediaWiki.r91106. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91106#c18980 Commit summary:
Add wfUnserialize() wrapper around unserialize to prevent E_NOTICE and use it in ExifBitmap.php. There are probably many more places that could use this. This should fix Platonides' problem at r90421, but also added a check for $wgShowExif to prevent the test from failing. Comment: I believe the intention is that if metadata is bad, we go to the file and get new metadata. If the file is broken we'd re-get the metadata on each page view because it'd never be good, which would be bad for efficiency. (I agree that the whole isMetadataValid thing could be better) _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
