User "Dantman" changed the status of MediaWiki.r91496. Old Status: new New Status: fixme
User "Dantman" also posted a comment on MediaWiki.r91496. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91496#c19231 Commit summary: DumpHTML fixes: * Made SkinOffline use getTitle() instead of non-existing mTitle * Made getArticleHTML() use RequestContext (follow-up r85250) Comment: Wrong way to handle OutputPage. That should be: <pre> $context = new RequestContext(); $context->setTitle( $title ); $context->setUser( $wgUser ); $wgTitle = $title; // b/c $wgOut = $context->getOutput(); $wgOut->parserOptions( new ParserOptions() ); // anon </pre> ie: Don't create your own OutputPage and set it, the RequestContext does it on it's own. Just fetch the one inside the context then use and alter it. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
