User "Krinkle" posted a comment on MediaWiki.r91844.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91844#c19410
Commit summary:

Add test suite for jquery.byteLimit:
- Tests to verify that the byteLength does not exceed the byteLimit when 
inserting more characters
- Tests to verify that it doesn't prevent too early (ie. if limit is 10 and we 
insert 20 characters, there should be 10 characters in the input field).

This test suite has exposed that the latter is currently broken. 
jquery.byteLimit is preventing characters to be added as soon as 
byteLength(currentValue) + 3 is more than the given limit.

(Follows-up r86698, r91148)

Comment:

Breakage recorded as [[bugzilla:29804]] (jquery.byteLimit should allow the 
limit to be reached).

Note that this revision didn't introduce the bug, it merely exposed it through 
a unit test.

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to