User "Reedy" posted a comment on MediaWiki.r91882.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91882#c19423
Commit summary:
Added Global statistics support
Comment:
1 very minor issue is
<pre>
if(! $is_new_rating ) {
</pre>
Should really be
<pre>
if( !$is_new_rating ) {
</pre>
The other is the usage of empty... [[Manual:Coding_conventions#PHP_pitfalls]]
_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
