User "Schnark" posted a comment on MediaWiki.r93090.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93090#c20286
Commit summary:
* Ignore any <nowiki> or comment sections
* More natural messages
* Respect wgCaseSensitiveNamespaces
* Regex: Add possible whitespace between "[[Category:" and the category name. (
[[Category: Foo]] )
* Make nearly all functions publicly accessible
* Add "cancel all" button
* Submit on enter keypress
* Check for redirects
* Color links correctly based on existance of category page
* Add a summary of the changes done into the edit summary ('+Category:foo,
-Category:Bar: Foo is not correct...')
* Add more error handlers
* Add more hooks ( afterChange/Delete/add ).
* Pass category names to the hooks
* Allow hooks to abort by returning false
* Handle sortkey correctly in all operations
* Move addCategory form below categories.
* Fix any known IE6 and IE7 bugs.
* Add more documentation
Comment:
You don't want to check for <code>wgCaseSensitiveNamespaces</code> in
<code>makeCaseInsensitive</code>, but in <code>buildRegex</code> when building
<code>firstChar</code> (which by the way you want to be a local variable).
_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
