User "Brion VIBBER" posted a comment on MediaWiki.r93563. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93563#c20315 Commit summary:
* (bug 30131) XCache with variable caching disabled no longer used for variable caching (CACHE_ACCEL) Patch from John Du Hart: https://bugzilla.wikimedia.org/attachment.cgi?id=8849&action=diff If XCache is present, but the xcache.var_size setting is off, we'll now consider it as xcache being disabled for CACHE_ACCEL purposes. It won't trigger view of the accelerator option in the installer, and at runtime if using CACHE_ACCEL and no other modules are available, it'll throw an error so you know that it doesn't work! Comment: Recommend for merge to 1.18 (hence putting it in the 1.18 release notes ;) and to 1.17 (where it'd go out in the next bugfix update). No need to copy it to 1.17wmf1 manually -- we don't use xcache in production. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview