User "SPQRobin" posted a comment on MediaWiki.r94350. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94350#c20943 Commit summary:
Fix r91886 thanks to johnduhart: check if it is an IP *before* stripping subpages, otherwise IP range blocking does not work Comment: I don't have phpunit installed to test it, but maybe it is a solution to put the IP code back, and replace <code>if( strpos( $target, '/' ) !== false )</code> with <code>if( strpos( $target, '/' ) !== false && !( IP::isValid( $target ) || IP::isValidBlock( $target ) ) )</code> ? _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
