User "Nikerabbit" posted a comment on MediaWiki.r89637. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89637#c20989 Commit summary:
Initial commit of new extension Notificator Comment: <pre>+if (!defined('MEDIAWIKI')) {</pre> This check is not needed if the file only contains a class. Please also run stylize.php on the files and indent stuff inside class with one level, as is the normal practice. getDiffCss can most likely be replaced with plain file_get_contents(). Though I don't like how the css is duplicated here. Does it somehow differ from the normal diff css or why do we need to copy it? _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview