User "Brion VIBBER" posted a comment on MediaWiki.r94702. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94702#c21350 Commit summary:
Fix a regression in search highlighting from r90092 Followup on r94609, r94681 test cases. This fixes the test case with a period that was failing; problem was not the period, but the space before. The changed regex in r90092 ended up including the preceding whitespace in the match, so the position of the match was coming up one character before the actual word -- thus offsetting the highlight by one char. Changed from search to match, using the regex's index property (same as search returns) and adding in the length of the first match component which covers the space/whatever Comment: That highlight appears to work; it just matches in two places, while your expected text only lists one. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
