User "Schnark" posted a comment on MediaWiki.r94421.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94421#c21576
Commit summary:

(bug 26283) Previewing user JS/CSS pages doesn't load other user JS/CSS pages

Comment:

I didn't test it, but I think this change will cause undesired behavior when 
previewing JS/CSS-subpages that are imported by common.js/...

Let's assume [[Special:MyPage/common.js]] contains
<syntaxhighlight lang="javascript">
importScript('User:USERNAME/script.js');
</syntaxhighlight>

If now I preview changes made to [[Special:MyPage/script.js]] this script will 
get executed twice: The old version via <code>common.js</code> and 
<code>importScript</code>, the new version via the inline script. This is 
likely to cause some trouble.

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to