User "Brion VIBBER" posted a comment on MediaWiki.r95663. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95663#c21604 Commit summary:
Last commit to make WMF-deployed extensions HTTPS-ready (hopefully): use wfExpandUrl() in a bunch of places * SpamBlacklist: code is weird but I'm pretty sure this needs HTTP * ContributionTracking: expand return URL to current protocol. Use HTTP in the test suite (PROTO_CURRENT makes no sense in tests since they run from the command line) * GlobalUsage: remove URL expansion, not needed after r95651 * CentralNotice: expand URL because it gets fed to window.location indirectly via JS * OpenSearhXml: use canonical URLs in XML output * MobileFrontend: expand a URL that's used in a Location: header Comment: Shouldn't ApiOpenSearchXml::formatItem() use PROTO_CURRENT for the image thumbnail as well as the link? Feels wrong to deliberately load mixed content here. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
