User "Catrope" changed the status of MediaWiki.r95818. Old Status: new New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r95818. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/95818#c21666 Commit summary: [ResourceLoader2]: Initial go at the GadgetManager. * Front-end for overview is done * Front-end for gadgetview is just a stub * Removed code that was planned to be used with action=modify/action=delete. This is no longer going to be done from a Special-page. Prop-editor will be ajax-only. * Cleaned up log-related stuff that is no longer going to be used in (i18n and Gadgets.php) Comment: <pre> - $wgOut->addModuleStyles( 'ext.gadgets.gadgetmanager' ); ... + $out->addModules( 'ext.gadgets.gadgetmanager' ); </pre> I saw you added <code>'position' => 'top'</code> so there's no FOUC here, but this still means the overview will be unstyled in noscript mode. <pre> + if ( $category != '' ) { </pre> Use strict comparison. <pre> + $html .= '<table class="mw-gadgetmanager-gadgets TablePager"><tr>'; </pre> Why does this table have the TablePager CC class if it wasn't output by the TablePager PHP class? OK otherwise. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
