User "^demon" changed the status of MediaWiki.r95697. Old Status: new New Status: fixme
User "^demon" also posted a comment on MediaWiki.r95697. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95697#c21688 Commit summary: Switched BannerAllocation form from post to get. See bug 30271. Comment: * Has a weird mix of tabs and spaces, we use tabs for indentation. * If <tt>$locationSubmitted</tt> is just going to be a boolean and you don't need the actual value, you can use <tt>$wgRequest->getBool()</tt> and it'll be clearer :) * In <tt>$this->project = $wgRequest->getText( 'project', 'wikipedia', $wgNoticeProject );</tt>, I'm not sure what the 3rd parameter is for. <tt>getText()</tt> only takes 2 parameters. If you haven't already, I'd recommend reading our [[Manual:Coding conventions|coding conventions]] page. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
