User "Dantman" posted a comment on MediaWiki.r87340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87340#c21782 Commit summary:
Moved "printfooter" and debug HTML away from "bodytext" so that they can be easily modified by extensions with the SkinTemplateOutputPageBeforeExec hook; always moved generation of debug HTML just before executing the hook so that it includes more items Comment: I don't know how well this was thought out. It means that every 3rd party skin already using bodytext needs to be updated to add printfooter and debughtml after it to opt-back-in to the same behaviour they had before. This seams like a change that would have been better done by creating a replacement for bodytext, and combining the 3 keys back into bodytext after or before the hook (not sure which is best). Then skins can opt-in to controlling where things go by using the new messages, but extensions will still get most of the same behaviour even if the skin is still using the same bodytext as before. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
