User "Siebrand" posted a comment on MediaWiki.r96408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96408#c22022 Commit summary:
* Use static methods instead of an extension function to create an object and set the hooks * Always declare $wgHidensNamespaces to avoid register_globals vulnerability * Fix comment Comment: Hook methods should be split off the init file into a hooks file/class. I can imagine you're not volunteering for this immediately, but would it be a good idea to add a "@todo FIXME" for that in the file. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview