User "Catrope" changed the status of MediaWiki.r91327. Old Status: new New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r91327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91327#c22041 Commit summary: * Fixed getLatest() check in Article * Added Title::loadFromRow() function and made WikiPage::loadPageData() use it; avoids raw Title field accessing * Added Revision::newFromPageId() function and changed WikiPage::loadLastEdit() to use it. This makes it try a slave first instead of always hitting the master. It also makes it more consistent with getLatest() for sanity. * Made WikiPage::loadPageData() use accessor for Title::mRestrictionsExpiry Comment: <pre> + } else { // page not found + $this->mArticleID = 0; + $this->mLength = 0; + $this->mRedirect = false; + $this->mLatestID = 0; </pre> These defaults do not correspond to the ones you removed from newFromRow(). _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview