User "Catrope" posted a comment on MediaWiki.r96400.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96400#c22048
Commit summary:

Fix for total extension breakage due to protocol relative URLs

Comment:

Hmm, right. Is PROTO_CURRENT safe to use in this case, from a cache pollution 
standpoint? If so, then this rev is fine other than that the wfExpandUrl() call 
should really be unconditional (it doesn't touch fully-qualified URLs, and I 
trust wfExpandUrl()'s detection of those (using parse_url()) more than this 
simplistic if statement).

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to