User "Aaron Schulz" posted a comment on MediaWiki.r91327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91327#c22069 Commit summary:
* Fixed getLatest() check in Article * Added Title::loadFromRow() function and made WikiPage::loadPageData() use it; avoids raw Title field accessing * Added Revision::newFromPageId() function and changed WikiPage::loadLastEdit() to use it. This makes it try a slave first instead of always hitting the master. It also makes it more consistent with getLatest() for sanity. * Made WikiPage::loadPageData() use accessor for Title::mRestrictionsExpiry Comment: They shouldn't. This is for when the entire row object is false, not where just a field is missing. newFromRow() should work the same since loadFromRow() only sets fields given in $row, and the others fall back to the constructor defaults. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
