User "Reedy" posted a comment on MediaWiki.r96669.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96669#c22266
Commit summary:

Kill off $wg{Request,User,Lang,Output} usage within skins/ and redundant 
$this->skin local vars.

Comment:

<pre>
-               if ( $wgUser->getOption( 'underline' ) < 2 ) {
-                       $underline = "text-decoration: " . $wgUser->getOption( 
'underline' ) ? 'underline !important' : 'none' . ";";
+               if ( $this->getSkin()->getUser()->getOption( 'underline' ) < 2 
) {
+                       $underline = "text-decoration: " . 
$this->getSkin()->getUser()->getOption( 'underline' ) ? 'underline !important' 
: 'none' . ";";
                }
</pre>

Can we just not use $this->getUser() ?

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to