User "Reedy" posted a comment on MediaWiki.r91561.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91561#c22665
Commit summary:

(Bug 19725) Do not include suppressed edits in the "View X deleted edits" 
message, and when doing prefix search of special:undelete.

I'm not 100% sure this is the right thing to do, see the bug for the details. 
But basically this doesn't include an edit in the count if its text is hidden 
and its hidden from admins. (Not sure if it should not be included only if 
everything is hidden). Its also weird to show people different things depending 
if they have suppress rights, without really indicating that.

Minor db note: This causes the query to no longer use a covering index. I don't 
think that matters but just thought i'd mention.

p.s. The upload page show deleted edits link is broken right now, (from before) 
I'll fix in a follow-up.

Comment:

Rarrrrgh

Everything but the RELEASE-NOTES conflict

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to