User "Brion VIBBER" posted a comment on MediaWiki.r43471. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/43471#c22793 Commit summary:
Fix incorrect use of Title::newFromText(). That function lets the user choose the namespace using a title with colons, to force the namespace you must use Title::makeTitleSafe(). Images are always in the image namespace. Comment: Since this change, you can no longer pass titles with the namespace to Special:Filepath -- eg 'Image:Wiki.png' or 'File:Wiki.png' now gets interpreted as 'File:Image:Wiki.png' or 'File:File:Wiki.png' which is invalid. Bug 30977 talks about some issues with handling directionality on the name of the file namespace as it's exposed in a message on this page saying to input the filename "without the File: prefix" -- that bit of instruction text becomes wholly unnecessary if this rev is reverted. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
