User "Brion VIBBER" posted a comment on MediaWiki.r98583.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98583#c23905
Commit summary:

* (bug 26028) Preserve initial newlines in ProofreadPage customized edit 
interface.

Same basic problem as bug 12130, but not fixed by that fix because 
ProofreadPage creates its own <textarea>s as HTML strings in JavaScript, where 
fixes to Html::textarea() in PHP-land have no effect. :)

Comment:

r99164 should fix this up. ProofreadPage was adding a newline inside the footer 
on every save, which was only visible on the first edit because on subsequent 
edits the newline got silently eaten in the textarea and then re-inserted again 
on save.

Moved the inserted newline from inside the footer's &lt;noinclude> to outside 
it, so we still make sure there's a newline before the header but it's in a 
place where extra newlines get trimmed (end of body area) so it won't grow 
forever.


_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to