User "Khorn (WMF)" posted a comment on MediaWiki.r98202.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98202#c24184
Commit summary:

More refactoring work for the gateway adapters, mostly surrounding the special 
page itself.

Comment:

Point 1: Resource Loaderification. This will have to get dealt with as part of 
the merge back into trunk (see revision r99077). In order to accomplish this, 
among many other things, the validate.input.js file will have to be moved to a 
gateway-agnostic location (probably the gateway_forms directory makes the most 
sense), and the resource module definitions will need to move to 
donationinterface.php, as the payflowpro_gateway.php file no longer exists. 

Point 2: ...Ah, I think I see what's going on here: It looks like this was 
partially dealt with in trunk (same commit: r99077) with the 
form_placeholders.js now coming in through ResourceLoader. However, it looks 
like there's still some moderate lifting to be done there: If I'm reading all 
this correctly, that means all the messages previously defined in 
addErrorMessageScript need to be moved out of there, and instead loaded into 
the placeholders module as messages. As this is at least partially dependent on 
a change made in trunk after the initial branching, I'm inclined to tag that 
work as also being part of the merge process...

Point 3: fixed in r99606

Point 4: fixed in r99613

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to