User "Valhallasw" changed the status of pywikipedia.r9625. Old Status: new New Status: fixme
User "Valhallasw" also posted a comment on pywikipedia.r9625. Full URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9625#c24256 Commit summary: query.py:fix password invisible in verbose mode Comment: If I remember correctly, the == 1 was on purpose, as the full HTTP requests will be shown for verbose > 1 anyway - the idea being it's better to show all passwords than to only remove some (giving the false impression all of them are removed). Did you either adapt/check that all passwords (as well as session tokens) are removed? If not, I would suggest reverting this change. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
