* Platonides <platoni...@gmail.com> [Wed, 26 Oct 2011 10:05:42 +0200]: > Platonides wrote: > > Jeremy Baron wrote: > >> Seems pretty clearly broken; we should fix the way we quote. (and > >> maybe not break anyone because anyone using the syntax that triggers > >> this would already be broken because of this) Maybe we need backticks > >> instead of quotes? I can test when I'm less sleepy but maybe someone > >> else knows. Looks like it per > >> http://dev.mysql.com/doc/refman/5.0/en/identifiers.html > > > > Yes, the problem is that it is using parameter quoting instead of > > identifier quoting. > > Was quite obvious once I was looking at it on mysql-cli. > > However, conversion is done correctly for me both in trunk and REL1_18. > I just compared 1.17 release and my farm code and there are few differences in /includes/db/Database.php
< return $this->tableName( $name ) . ' ' . $this->addIdentifierQuotes( $alias ); --- > return $this->tableName( $name ) . ' ' . $this->addQuotes( $alias ); It seems that I am running not an release but some earlier version. I'll try to update later to see whether it works. Sorry if my previous bugreport was false - I'll check and close it. A bit strange though because I am sure I am not running early alpha of 1.17, but something quite close to release. Dmitriy _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
