User "Nikerabbit" posted a comment on MediaWiki.r100884. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100884#c24965 Commit summary:
[RL2] Turn getAllGadgets() into a versatile helper function that supports getting all gadgets with and without local gadgets, as either ID strings or Gadget objects. Also add isLocal() to the GadgetRepo class, because instanceof LocalGadgetRepo is problematic (since ForeignDBGadgetRepo inherits from LocalGadgetRepo). Comment: Wouldn't it be cleaner to have one function which returns ids and another one which returns objects when given ids? _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
