User "Yair rand" posted a comment on MediaWiki.r100359. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100359#c24974 Commit summary:
add search suggestions to MF Comment: I think it would be much better to use JSON for the search suggestions instead of XML. Also, creating the content of the suggestions box through innerHTML is probably worse than just working with document.createElement. (I'm don't really understand what the relation is between this js file and application.js, but if there used on the same page there are some redundant variables, and also two eventlisteners which could be merged.) _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
