User "Khorn (WMF)" posted a comment on MediaWiki.r100942. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100942#c24998 Commit summary:
Added GlobalCollectTestAdapter for testing the GlobalCollect adapter. Comment: Awesome. You may want to consider adding back in some of the functionality you killed off in r100625. Particularly, the part where the curl function was being overridden to ensure that tests you do using this object remain local, but that it returns _something_ (under your control, of course) that the rest of the object can handle normally. In my experience, it is a _very_ good idea to strongly segregate all your local testing, from everything that might have the slightest, remotest possibility of actually contacting a server, particularly if it has the slightest possibility of triggering real money changing hands in a rapid-fire, automated kind of way. The best way to do this is to always ONLY run automated tests on a special object, on which you have specially damaged the outbound communication functions beyond repair. In the gateway adapter object, I have purposefully limited all outbound communication to the curl_transaction function, to make this sort of thing easy. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
