User "MZMcBride" posted a comment on MediaWiki.r104128.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104128#c26479
Commit summary:

provide login support

Comment:

Expanding my previous comment...

* the "EOT" syntax doesn't seem to fit in with MediaWiki's style, as far as I 
know; I thought things where done through $wgOut (for escaping, consistency, 
etc.)
* form doesn't use HTMLForm (comment at r104131)
* not sure a separate form/logic is needed here; I'd try to call as much core 
code as possible for form generation like this, otherwise you risk rewriting 
much of the software, don't you?
** this is apparently to get different styling; should be limited to CSS changes
** the last time I looked, the Userlogin.php code in core was a God-awful mess, 
but someone may have cleaned it up; once it's cleaned up, it shouldn't be too 
difficult to re-use
* ideologically, this is a big step for the mobile site (supporting non-read 
actions), but I assume that was already discussed

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to