User "Dantman" posted a comment on MediaWiki.r104334.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104334#c26583
Commit summary:

* Use WikiPage instead of Article in Skin and SkinTemplate
* Added $context parameter to Action::factory() to allow callers passing a 
WikiPage object in addition to Article (otherwise this would throw a fatal 
error in getContext() since WikiPage::getContext() does not exist)

Comment:

This pattern of passing both a WikiPage referring to a title and a Context 
which contains a title looks completely messed up.

I started a wikitech-l discussion on a better way to do this:
http://thread.gmane.org/gmane.science.linguistics.wikipedia.technical/56890

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to