User "MaxSem" changed the status of MediaWiki.r94762. Old Status: fixme New Status: new
User "MaxSem" also posted a comment on MediaWiki.r94762. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94762#c26590 Commit summary: Started rewriting WikiHiero. So far, only parser tag works while the maint functions are broken (however, they're disabled anyway) * Turned global functions into a class * Made images accessible via $wgExtensionAssetsPath instead of $wgScriptPath to make baby Domas not cry :) * The code still needs much more structural changes and stylization - will be done with next commits Comment: Static/nonstatic fixed in r104256, indentation in r104352. Looks like PHP 5.3 doesn't consider such calls anything illegal, e.g.: <pre> <?php error_reporting( E_ALL | E_STRICT ); ini_set( 'display_errors', 1 ); class Foo { public function a() { ereg( ' ', '' ); // E_DEPRECATED here, error reporting works self::b(); // but no warning here! echo "a(): bar={$this->bar}\n"; } public function b() { $this->bar = 'bar'; echo "b()!\n"; } } $foo = new Foo; $foo->a(); </pre> That's why I didn't notice this. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
