"Tim Starling" changed the status of MediaWiki.r95043 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95043#c27165
Old Status: new > New Status: fixme Commit summary for MediaWiki.r95043: line numbers and better style * new system to parse the diff, see parseLine() dispatcher. * show lines numbering for each chunk. * tweak style to replace the <pre> look'n feel, removing the first-child last-child selectors. * line numbers are not selected on mouse selection. Makes it easy to copy paste the patch. Note: old code left unchanged. To use it again, change the array_map callback in splitLines from 'parseLine' to 'colorLine'. Tim Starling's comment: Marking fixme for the stored XSS in formatLine(). Please escape both $class and $content. Use Html::element(). _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview