"Tim Starling" changed the status of MediaWiki.r95427 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95427#c27167
Old Status: ok > New Status: fixme Commit summary for MediaWiki.r95427: add an id to each line of the CR diff Tim Starling's comment: getLineIdAttr() should return an array and the HTML construction part should use Html::element() so the security is easier to verify. sprintf() should not be used for constructing HTML in new code. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
